ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1116207172
##########
core/src/main/scala/kafka/server/DelayedDeleteRecords.scala:
##########
@@ -122,12 +121,12 @@ class DelayedDeleteRecords(delayMs: Long,
}
}
-object DelayedDeleteRecordsMetrics extends KafkaMetricsGroup {
+object DelayedDeleteRecordsMetrics {
+ private val metricsGroup = new KafkaMetricsGroup(this.getClass)
Review Comment:
Same as with `LogFlushStats`.
##########
core/src/main/scala/kafka/server/DelayedFetch.scala:
##########
@@ -180,9 +181,10 @@ class DelayedFetch(
}
}
-object DelayedFetchMetrics extends KafkaMetricsGroup {
+object DelayedFetchMetrics {
+ private val metricsGroup = new KafkaMetricsGroup(this.getClass)
Review Comment:
Same as with `LogFlushStats`.
##########
core/src/main/scala/kafka/server/DelayedProduce.scala:
##########
@@ -129,15 +129,16 @@ class DelayedProduce(delayMs: Long,
}
}
-object DelayedProduceMetrics extends KafkaMetricsGroup {
+object DelayedProduceMetrics {
+ private val metricsGroup = new KafkaMetricsGroup(this.getClass)
Review Comment:
Same as with `LogFlushStats`.
##########
core/src/main/scala/kafka/tools/MirrorMaker.scala:
##########
@@ -61,7 +61,8 @@ import scala.util.{Failure, Success, Try}
* @deprecated Since 3.0, use the Connect-based MirrorMaker instead (aka MM2).
*/
@deprecated(message = "Use the Connect-based MirrorMaker instead (aka MM2).",
since = "3.0")
-object MirrorMaker extends Logging with KafkaMetricsGroup {
+object MirrorMaker extends Logging {
+ private val metricsGroup = new KafkaMetricsGroup(this.getClass)
Review Comment:
Same as with `LogFlushStats`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
