[GitHub] [kafka] philipnee commented on a diff in pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

[via GitHub]

philipnee commented on code in PR #13270:
URL: https://github.com/apache/kafka/pull/13270#discussion_r1117278567


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -355,6 +355,12 @@ protected synchronized long timeToNextHeartbeat(long now) {
         // we don't need to send heartbeats
         if (state.hasNotJoinedGroup())
             return Long.MAX_VALUE;
+        if (heartbeatThread != null) {

Review Comment:
   I'm also curious, do we actually need to perform null check for 
heartbeatThread? We will always create one when we try or already be in a group 
no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org