kirktrue commented on PR #12813: URL: https://github.com/apache/kafka/pull/12813#issuecomment-1446745731
@dajac I'm having a bit of a hard time figuring out how to test this. Per your previous comments, the `NetworkClient` already issues a request for metadata update when the connection disconnects. However, because the `SenderTest` doesn't leverage `NetworkClient`, and instead uses `MockClient`, it's not possible to rely on that behavior. To fix this, I tried to update `MockClient` to have similar semantics to the `NetworkClient` with respect to when it handles disconnects and metadata updates, but that doesn't really "feel" right because it doesn't prove anything. I'm now thinking that I need to maybe handle this test in an integration test. I'll look into that now. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
