C0urante commented on code in PR #13287:
URL: https://github.com/apache/kafka/pull/13287#discussion_r1120636637
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -427,9 +427,8 @@ private void updateConnectorTasks(String connName) {
}
List<Map<String, String>> newTaskConfigs =
recomputeTaskConfigs(connName);
- List<Map<String, String>> oldTaskConfigs =
configState.allTaskConfigs(connName);
- if (!newTaskConfigs.equals(oldTaskConfigs)) {
Review Comment:
I think the most convincing argument here is point 1; any duplication of
work that isn't inevitable can be addressed to the same degree regardless of
which class contains the logic, and I don't think the risk of improving the
naive search is super high.
Anyways, sounds good to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
