divijvaidya commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1449651799
Hi @maniekes, I see that this is your first contribution to Apache Kafka. Congratulations :tada: However, I have some reservations about this change. We try to ensure that whatever we ship in a version release works fine. For that, we perform varies types of unit, integration and version upgrade tests during the release process. These are executed via jenkins on Apache infrastructure hosts. But changes such as this PR can not be tested since we do not have testing infra for it. Which means, over a period of time, it would not be possible to support Mingw64 . Now, we could either say, that as a project we will do a best effort support for mingw64 but can't guarantee it will work (since we don't test it) OR we can say that we don't support it at all. The latter approach is not inclusive but the former is flaky at best. I am tagging some PMC members here to hear about what they have to say about adding code for non-standard/unsupported platforms in our code base. Let's go from there. @mimaison @ijuma what are your thoughts on the topic on testability and addition of support for various platform in our code base? Do we require a DISCUSS thread in mailing list to discuss this further or do we merge this since it is a small change in the bash scripts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
