dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1121501980
##########
clients/src/test/java/org/apache/kafka/common/requests/TxnOffsetCommitRequestTest.java:
##########
@@ -80,10 +81,10 @@ public void setUp() {
);
}
- @Test
@Override
- public void testConstructor() {
-
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.TXN_OFFSET_COMMIT)
+ public void testConstructor(short version) {
Review Comment:
Is this change related to the PR? If not, I would rather do it in a separate
PR.
##########
clients/src/test/java/org/apache/kafka/common/requests/TxnOffsetCommitResponseTest.java:
##########
@@ -38,9 +40,9 @@ public void testConstructorWithErrorResponse() {
assertEquals(throttleTimeMs, response.throttleTimeMs());
}
- @Test
- @Override
- public void testParse() {
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.TXN_OFFSET_COMMIT)
Review Comment:
Same question here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
