cmccabe opened a new pull request, #13332:
URL: https://github.com/apache/kafka/pull/13332

   This PR allows us to dynamically reconfigure the KRaft controller by setting 
either a cluster configuration (that is, a configuration that applies to all 
resource of type BROKER), or by configuring a combined broker/controller node.
   
   As described in DynamicBrokerConfig#addReconfigurables(ControllerServer), we 
currently support reconfiguring Yammer metrics, metrics reporters, the socket 
server, and the Authorizer.  More dynamically reconfigurable Controller 
elements will be added later.
   
   This PR refactors MetadataPublisher's interface a bit. There is now a 
handleControllerChange callback. This is something that some publishers might 
want (a good example is ZkMigrationClient). There is now only a single 
publish() function rather than a separate function for publishing snapshots and 
log deltas. Most publishers didn't want to do anything different in those two 
cases. The ones that do want to do something different for snapshots can always 
check the manifest type. The close function now has a default empty 
implementation, since most publishers didn't need to do anything there.
   
   This PR fixes a bug where the KRaft broker's authorizer was not dynamically 
reconfigurable even if it had implemented Reconfigurable. The bug resulted from 
the fact that we called DynamicBrokerConfig.addReconfigurables prior to 
initializing BrokerServer.authorizer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to