viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076
########## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.config.provider; + +import org.apache.kafka.common.config.ConfigData; +import org.apache.kafka.common.config.ConfigException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +public class EnvVarConfigProvider implements ConfigProvider { + private final Map<String, String> envVarMap; + + public EnvVarConfigProvider() { + envVarMap = getEnvVars(); + } + + public EnvVarConfigProvider(Map<String, String> envVarsAsArgument) { + envVarMap = envVarsAsArgument; + } + + private static final Logger log = LoggerFactory.getLogger(EnvVarConfigProvider.class); + + @Override + public void configure(Map<String, ?> configs) { + } Review Comment: Recently we had [CVE-2023-25194](https://nvd.nist.gov/vuln/detail/CVE-2023-25194) which also assumes an authorized user. In this sense I think it's good to not assume users with certain levels of access as non-malicious, although this case indeed seems to be less severe as the configuration isn't enabled by default and requires a very high level access (like modify connect configuration) but allows some kind of exploitability by trial and error. So if it's already implemented and we default to the most sensible values, I don't mind this change. ########## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.config.provider; + +import org.apache.kafka.common.config.ConfigData; +import org.apache.kafka.common.config.ConfigException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +public class EnvVarConfigProvider implements ConfigProvider { + private final Map<String, String> envVarMap; + + public EnvVarConfigProvider() { + envVarMap = getEnvVars(); + } + + public EnvVarConfigProvider(Map<String, String> envVarsAsArgument) { + envVarMap = envVarsAsArgument; + } + + private static final Logger log = LoggerFactory.getLogger(EnvVarConfigProvider.class); + + @Override + public void configure(Map<String, ?> configs) { + } Review Comment: Recently we had [CVE-2023-25194](https://nvd.nist.gov/vuln/detail/CVE-2023-25194) which also assumes an authorized user. In this sense I think it's good to not assume users with certain levels of access as non-malicious, although this case indeed seems to be less severe as the configuration isn't enabled by default and requires a very high level access (like modify connect configuration) but allows some kind of exploitability by trial and error. So if it's already implemented and we default to the most sensible values, I don't mind this addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
