cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176972
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -911,7 +954,22 @@ object DynamicListenerConfig {
)
}
-class DynamicClientQuotaCallback(server: KafkaBroker) extends Reconfigurable {
+trait DynamicClientQuotaCallbackServer {
Review Comment:
We don't really need a trait for this, do we? It's just two objects that we
can pass to the constructor of `DynamicClientQuotaCallback`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
