jlprat commented on code in PR #13223:
URL: https://github.com/apache/kafka/pull/13223#discussion_r1127673459
##########
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##########
@@ -89,7 +89,7 @@ class KafkaRaftServer(
Some(new ControllerServer(
sharedServer,
KafkaRaftServer.configSchema,
- bootstrapMetadata,
+ bootstrapMetadata
Review Comment:
Same as above.
##########
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##########
@@ -73,7 +73,7 @@ class KafkaRaftServer(
metrics,
threadNamePrefix,
controllerQuorumVotersFuture,
- new StandardFaultHandlerFactory(),
+ new StandardFaultHandlerFactory()
Review Comment:
This is not necessarily a typo, but rather the "trailing comma" feature,
hence I wouldn't add this in this PR.
##########
core/src/main/scala/kafka/server/SharedServer.scala:
##########
@@ -102,7 +102,7 @@ class SharedServer(
@volatile var brokerMetrics: BrokerServerMetrics = _
@volatile var controllerMetrics: QuorumControllerMetrics = _
@volatile var loader: MetadataLoader = _
- val snapshotsDiabledReason = new AtomicReference[String](null)
+ val snapshotsDisabledReason = new AtomicReference[String](null)
Review Comment:
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
