Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1131139080
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##########
@@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {
return version >= 4;
}
+ public short version() {
+ return version;
+ }
+
public static class Builder {
OffsetCommitResponseData data = new OffsetCommitResponseData();
HashMap<String, OffsetCommitResponseTopic> byTopicName = new
HashMap<>();
+ private final TopicResolver topicResolver;
+ private final short version;
+
+ public Builder(TopicResolver topicResolver, short version) {
Review Comment:
Sounds good. Thanks for your guidance. As you mentioned, this PR is already
quite large, so if you agree, I will go ahead and implement this change first,
in a PR of its own. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
