vamossagar12 commented on PR #13376: URL: https://github.com/apache/kafka/pull/13376#issuecomment-1463648551
@C0urante , I created a draft PR based on the approach I outlined here: https://issues.apache.org/jira/browse/KAFKA-14091?filter=-1#:~:text=added%20a%20comment%20%2D-,06/Mar/23%2012%3A37,-%2D%20edited I am not very happy with this though. I feel I am exposing too much of state (worker -> herder -> member -> coordinator -> assignor). The assignor ideally doesn't care for the herder but for me to be able to fence out the open transactions from lost tasks, I need herder. The other approach that I was thinking that could be used is to extend the ExtendedAssignment to include lost tasks? This way, the rebalanceListener in DistributedHerder would have access to the the lostTasks in `onAssigned` method and should be able to kill those transactions. This way, it fits in nicely into the current scheme. But would it be too invasive (i.e need a KIP? Let me know what you think :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
