[GitHub] [kafka] dajac commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

[via GitHub]

dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132487254


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator(
       if (validationErrorOpt.isDefined) {
         responseCallback(offsetMetadata.map { case (k, _) => k -> 
validationErrorOpt.get })
       } else {
+        // GroupMetadataManager does not support topic ids yet.

Review Comment:
   I don't really see the need for `TopicIdAdaptor`. Could we just update 
`storeOffsets` to take `TopicIdPartition` as well? Updating the method 
signatures is fine but we should not update the underlying Map where offsets 
are stored. Am I missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org