CalvinConfluent commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1132965843
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -1103,14 +1136,18 @@ class ReplicaFetcherThreadTest {
assertProcessPartitionDataWhen(isReassigning = false)
}
- @Test
- def testBuildFetch(): Unit = {
+ @ParameterizedTest
+ @ValueSource(booleans = Array(true, false))
+ def testBuildFetch(usingReplicaState: Boolean): Unit = {
Review Comment:
Actually, for the ReplicaFetchThread, we don't have anything to test. We
have tested RemoteLeaderEndPoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
