cmccabe commented on code in PR #13344:
URL: https://github.com/apache/kafka/pull/13344#discussion_r1134579225
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -362,16 +326,13 @@ class BrokerServer(
config.brokerSessionTimeoutMs / 2 // KAFKA-14392
)
lifecycleManager.start(
- () => metadataListener.highestMetadataOffset,
+ () => sharedServer.loader.lastAppliedOffset(),
Review Comment:
This is a good question. It is indeed a slightly different semantic, and the
PR description should call that out.
As you said, previously we were not waiting for the updates we loaded to
actually be published. Now we are. The intention was always to wait for the
updates to actually be propagated before declaring the broker "caught up" so
this is really fixing a bug. I'll make a note in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
