cmccabe commented on code in PR #13372: URL: https://github.com/apache/kafka/pull/13372#discussion_r1134596431
########## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ########## @@ -269,15 +288,24 @@ public void close() throws Exception { // Events handled by Migration Driver. abstract class MigrationEvent implements EventQueue.Event { + @SuppressWarnings("ThrowableNotThrown") @Override public void handleException(Throwable e) { - if (e instanceof RejectedExecutionException) { - log.info("Not processing {} because the event queue is closed.", this); + if (e instanceof MigrationClientAuthException) { + KRaftMigrationDriver.this.faultHandler.handleFault("Encountered client auth error in " + this, e); + } else if (e instanceof MigrationClientException) { + log.debug(String.format("Encountered client error during event %s. Will retry.", this), e.getCause()); Review Comment: I think this should be `info`... for now, at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org