cmccabe opened a new pull request, #13390: URL: https://github.com/apache/kafka/pull/13390
Standardize KRaft thread names a bit. Event handler threads should be prefixed with the manager name and node id. For example, the BrokerLifecycleManager event handler thread for node 2 should be "BrokerLifecycleManager2EventHandler". (Prior to this PR, we had several threads just named "EventHandler" which was not helpful for debugging. And some thread names had a prefix, but not a node ID, making debugging JUnit tests difficult.) Also, some thread names previously mixed underscores, dashes, etc. which was just ugly. For KafkaRaftManager threads, we were overwriting the "kafka-raft" prefix, which led to thread names like "controller0-io-thread", rather than "controller0-raft-io-thread". Fix this by having SharedServer set the appropriate prefix. For BrokerToControllerChannelManager, in tests, name the thread for broker 0 as broker0ToControllerChannelManager. The previous thread name used in junit tests included a colon and was unwieldy. The thread name for the non-junit-test-case is unaffected. Standardize KRaft log prefixes as [ComponentName <nodeId>]. So for a ControllerServer with ID 123, we will have [ControllerServer 123], and so on. For the QuorumController class, use the prefix [QuorumController <nodeId>] rather than [Controller <nodeId], to make it clearer that this is a KRaft controller. Standardize terminology. The two KRaft modes are combined and isolated. All synonyms of combined (colocated, coresident, etc.) should be replaced by "combined"). All synonyms of isolated (remote, non-colocated, distributed, etc.) should be replaced by "isolated". This includes in ducktape tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
