divijvaidya commented on code in PR #13284:
URL: https://github.com/apache/kafka/pull/13284#discussion_r1135316350
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/DedicatedMirrorIntegrationTest.java:
##########
@@ -62,8 +60,10 @@ public void setup() {
@AfterEach
public void teardown() throws Throwable {
AtomicReference<Throwable> shutdownFailure = new AtomicReference<>();
- mirrorMakers.forEach((name, mirrorMaker) ->
- Utils.closeQuietly(mirrorMaker::stop, "MirrorMaker worker '" +
name + "'", shutdownFailure)
+ mirrorMakers.forEach((name, mirrorMaker) -> {
+ Utils.closeQuietly(mirrorMaker::stop, "MirrorMaker worker '" +
name + "'", shutdownFailure);
+ mirrorMaker.awaitStop();
+ }
Review Comment:
done in latest commit.
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/DedicatedMirrorIntegrationTest.java:
##########
@@ -62,8 +60,10 @@ public void setup() {
@AfterEach
public void teardown() throws Throwable {
AtomicReference<Throwable> shutdownFailure = new AtomicReference<>();
- mirrorMakers.forEach((name, mirrorMaker) ->
- Utils.closeQuietly(mirrorMaker::stop, "MirrorMaker worker '" +
name + "'", shutdownFailure)
+ mirrorMakers.forEach((name, mirrorMaker) -> {
+ Utils.closeQuietly(mirrorMaker::stop, "MirrorMaker worker '" +
name + "'", shutdownFailure);
+ mirrorMaker.awaitStop();
+ }
Review Comment:
good idea. done in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
