tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1139190436
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -117,6 +122,16 @@ public MirrorSourceConnector() {
this.configPropertyFilter = configPropertyFilter;
}
+ // visible for testing the deprecated setting
"use.incremental.alter.configs"
+ // this constructor should be removed when the deprecated setting is
removed in Kafka 4.0
+ MirrorSourceConnector(SourceAndTarget sourceAndTarget, ReplicationPolicy
replicationPolicy,
+ String useIncrementalAlterConfigs,
ConfigPropertyFilter configPropertyFilter, Admin targetAdmin) {
+ this.sourceAndTarget = sourceAndTarget;
+ this.replicationPolicy = replicationPolicy;
+ this.configPropertyFilter = configPropertyFilter;
+ this.useIncrementalAlterConfigs = useIncrementalAlterConfigs;
+ this.targetAdminClient = targetAdmin;
+
Review Comment:
oops, that got lost when rebasing and resolving merge conflicts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
