[ https://issues.apache.org/jira/browse/KAFKA-14832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
zou shengfu updated KAFKA-14832: -------------------------------- Description: {code:java} groupManager.storeGroup(group, groupAssignment, error => { if (error != Errors.NONE) { warn(s"Failed to persist metadata for group ${group.groupId}: ${error.message}") // Failed to persist member.id of the given static member, revert the update of the static member in the group. group.updateMember(knownStaticMember, oldProtocols, oldRebalanceTimeoutMs, oldSessionTimeoutMs, null) val oldMember = group.replaceStaticMember(groupInstanceId, newMemberId, oldMemberId) .... }{code} Should we add a lock to protect group? was: {code:java} groupManager.storeGroup(group, groupAssignment, error => { if (error != Errors.NONE) { warn(s"Failed to persist metadata for group ${group.groupId}: ${error.message}") // Failed to persist member.id of the given static member, revert the update of the static member in the group. group.updateMember(knownStaticMember, oldProtocols, oldRebalanceTimeoutMs, oldSessionTimeoutMs, null) val oldMember = group.replaceStaticMember(groupInstanceId, newMemberId, oldMemberId) .... }{code} Should we add a lock to protecet group? > Thread unsafe for GroupMetadata when persisting metadata > --------------------------------------------------------- > > Key: KAFKA-14832 > URL: https://issues.apache.org/jira/browse/KAFKA-14832 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 3.3.2 > Reporter: zou shengfu > Assignee: zou shengfu > Priority: Major > > {code:java} > groupManager.storeGroup(group, groupAssignment, error => { > if (error != Errors.NONE) { > warn(s"Failed to persist metadata for group ${group.groupId}: > ${error.message}") > // Failed to persist member.id of the given static member, > revert the update of the static member in the group. > group.updateMember(knownStaticMember, oldProtocols, > oldRebalanceTimeoutMs, oldSessionTimeoutMs, null) > val oldMember = group.replaceStaticMember(groupInstanceId, newMemberId, > oldMemberId) .... }{code} > Should we add a lock to protect group? -- This message was sent by Atlassian Jira (v8.20.10#820010)