pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1145628810
########## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java: ########## @@ -23,13 +23,15 @@ public enum ScramMechanism { - SCRAM_SHA_256("SHA-256", "HmacSHA256", 4096), - SCRAM_SHA_512("SHA-512", "HmacSHA512", 4096); + SCRAM_SHA_256((byte) 1, "SHA-256", "HmacSHA256", 4096, 16384), Review Comment: Comment added! ########## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ########## @@ -73,7 +73,7 @@ public static Optional<MetadataVersion> recordToMetadataVersion(ApiMessage recor return Optional.empty(); } - BootstrapMetadata( + public BootstrapMetadata( Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org