vcrfxia commented on code in PR #13444:
URL: https://github.com/apache/kafka/pull/13444#discussion_r1147020240
##########
streams/src/main/java/org/apache/kafka/streams/state/Stores.java:
##########
@@ -166,6 +248,11 @@ public String metricsScope() {
* This store supplier can be passed into a {@link
#windowStoreBuilder(WindowBytesStoreSupplier, Serde, Serde)}.
* If you want to create a {@link TimestampedWindowStore} you should use
* {@link #persistentTimestampedWindowStore(String, Duration, Duration,
boolean)} to create a store supplier instead.
+ * <p>
+ * Note that it is not safe to change the value of {@code retentionPeriod}
between
Review Comment:
I worry slightly that adding this warning about not changing retention
period between restarts will give the false impression that it is OK to change,
for example, window size between restarts. While I don't think that's a good
idea, I also don't think anything necessarily breaks if a user does that
(unlike for history retention where something definitely could break, if
segment interval is changed under the hood as well) so it's unclear whether
that should be discouraged in the docs or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
