vamossagar12 commented on PR #13361: URL: https://github.com/apache/kafka/pull/13361#issuecomment-1482497859
> > I don't think that we should add retries when we already know that the exceptions that would be caught here are non-retriable. Additionally, it may be unsafe or incorrect to retry on an arbitrary exception, and may produce unexpected behavior in the consumer or in the worker. > > Fair point @gharris1727! I agree. I think the retries came into the picture because we were retrying on `TimeoutException` for example. However, they wouldn't make sense in cases where we know the exception is something non-retriable. Yeah TimeoutException is a tricky one because it is generally thrown after having waited for some amount of time (like `default.api.timeout.ms` when fetching position from a Consumer or listing topics.) So in sense the waiting has already happened post which we can ascertain that something is broken and yet it extends RetriableException which suggests it's transient. In this case, I would still lean on not retrying and failing everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
