rayokota commented on code in PR #13425:
URL: https://github.com/apache/kafka/pull/13425#discussion_r1148320558
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -797,24 +799,15 @@ public KafkaConsumer(Map<String, Object> configs,
config.getBoolean(ConsumerConfig.THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED),
config.getString(ConsumerConfig.CLIENT_RACK_CONFIG));
}
+ FetchConfig<K, V> fetchConfig = new FetchConfig<>(config,
keyDeserializer, valueDeserializer, isolationLevel);
Review Comment:
@kirktrue , these should be `this.keyDeserializer` and
`this.valueDeserializer`. Otherwise the original values may be null and will
cause an NPE on line 300 of `CompletedFetch.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
