jeqo commented on code in PR #13445:
URL: https://github.com/apache/kafka/pull/13445#discussion_r1149677176
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##########
@@ -856,11 +867,8 @@ public List<ConfigKeyInfo> connectorPluginConfig(String
pluginName) {
default:
throw new BadRequestException("Invalid plugin type " +
pluginType + ". Valid types are sink, source, converter, header_converter,
transformation, predicate.");
}
- List<ConfigKeyInfo> results = new ArrayList<>();
- for (ConfigDef.ConfigKey configKey :
configDefs.configKeys().values()) {
- results.add(AbstractHerder.convertConfigKey(configKey));
- }
- return results;
+ addConfigDefToResult(results, configDefs);
+ return new ArrayList<>(results);
Review Comment:
Used Set to build the result and avoid duplicates in case the configdef
comes with common configs -- which could be the case? Happy to adjust if
doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
