cmccabe commented on code in PR #13462:
URL: https://github.com/apache/kafka/pull/13462#discussion_r1150911803


##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -212,38 +216,67 @@ private MetadataLoader(
         this.uninitializedPublishers = new LinkedHashMap<>();
         this.publishers = new LinkedHashMap<>();
         this.image = MetadataImage.EMPTY;
-        this.eventQueue = new KafkaEventQueue(time, logContext,
+        this.eventQueue = new KafkaEventQueue(Time.SYSTEM, logContext,

Review Comment:
   Using mock time doesn't really work with deferred event queue stuff at the 
moment. I do want to fix this. But right now, it would make `MockTime` unusable 
to pass it to `KafkaEventQueue`.
   
   I will add a time accessor to `KafkaEventQueue` so it is at least clear when 
we're using the event queue time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to