urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153273084
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -71,9 +72,9 @@ public void start(Map<String, String> props) {
String connectorName = config.connectorName();
sourceAndTarget = new SourceAndTarget(config.sourceClusterAlias(),
config.targetClusterAlias());
groupFilter = config.groupFilter();
- sourceAdminClient = config.forwardingAdmin(config.sourceAdminConfig());
- targetAdminClient = config.forwardingAdmin(config.targetAdminConfig());
- scheduler = new Scheduler(MirrorCheckpointConnector.class,
config.adminTimeout());
+ sourceAdminClient =
config.forwardingAdmin(config.sourceAdminConfig("source-admin"));
+ targetAdminClient =
config.forwardingAdmin(config.targetAdminConfig("target-admin"));
+ scheduler = new Scheduler(config.entityLabel(), config.adminTimeout());
Review Comment:
I misunderstood, and thought that this applies to both client.ids and thread
names
For the Scheduler name, I will restore the classname part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
