[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

[via GitHub]

CalvinConfluent commented on code in PR #13408:
URL: https://github.com/apache/kafka/pull/13408#discussion_r1153811968


##########
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java:
##########
@@ -847,15 +849,15 @@ public void testShrinkAndExpandIsr() throws Exception {
         assertEquals(OptionalInt.of(0), ctx.currentLeader(topicIdPartition));
         long brokerEpoch = ctx.currentBrokerEpoch(0);
         PartitionData shrinkIsrRequest = newAlterPartition(
-            replicationControl, topicIdPartition, asList(0, 1), 
LeaderRecoveryState.RECOVERED);
+            replicationControl, topicIdPartition, 
generateIsrWithTestDefaultEpoch(asList(0, 1)), LeaderRecoveryState.RECOVERED);

Review Comment:
   Change to use varargs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org