dajac commented on code in PR #13432:
URL: https://github.com/apache/kafka/pull/13432#discussion_r1154222435
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java:
##########
@@ -260,12 +261,18 @@ public void onFailure(
.filter(future.lookupKeys()::contains)
.collect(Collectors.toSet());
retryLookup(keysToUnmap);
+ } else if (t instanceof UnsupportedVersionException) {
+ Map<K, Throwable> unrecoverableFailures =
+ handler.handleUnsupportedVersionException(
+ (UnsupportedVersionException) t,
+ spec.keys,
+ spec.scope instanceof FulfillmentScope);
Review Comment:
If the scope is NOT a FulfillmentScope, I think that we don't have to
`completeExceptionally` but rather to `retryLookup` like we do in the previous
branch. Am I wrong? If this is true, it may be better to completely separate
the two cases. For instance, we could also add
`handleUnsupportedVersionException` to the lookup strategy in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
