artemlivshits commented on code in PR #13463:
URL: https://github.com/apache/kafka/pull/13463#discussion_r1154150901
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -247,6 +251,11 @@ class BrokerServer(
)
alterPartitionManager.start()
+ val interBrokerSendLogContext = new LogContext(s"[InterBrokerSender
broker=${config.brokerId}]")
Review Comment:
Could probably name interBrokerSenderLogContext, so that "interBrokerSender"
is a common string to find all things related to interBrokerSender.
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -247,6 +251,11 @@ class BrokerServer(
)
alterPartitionManager.start()
+ val interBrokerSendLogContext = new LogContext(s"[InterBrokerSender
broker=${config.brokerId}]")
+ val networkClient: NetworkClient =
NetworkUtils.buildNetworkClient("InterBrokerSendClient", config, metrics, time,
interBrokerSendLogContext)
Review Comment:
I think now the networkClient got a purpose, so we could name it
interBrokerNetworkClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
