philipnee commented on code in PR #13269:
URL: https://github.com/apache/kafka/pull/13269#discussion_r1156483833
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -2484,6 +2511,48 @@ public void
shouldUpdateOffsetIfCorruptedRecordFollowsValid() {
);
}
+ @Test
+ public void shouldCheckpointAfterRestorationWhenAtLeastOnceEnabled() {
+ final ProcessorStateManager processorStateManager = mockStateManager();
+ recordCollector = mock(RecordCollectorImpl.class);
+ doReturn(singletonMap(partition1, 1L)).when(recordCollector).offsets();
+
+ task = createStatefulTask(createConfig(AT_LEAST_ONCE, "100"), true,
processorStateManager);
+ task.initializeIfNeeded();
+ task.completeRestoration(noOpResetter -> { });
+ verify(processorStateManager, times(1)).checkpoint();
+ verify(recordCollector, times(1)).offsets();
+ }
+
+ @Test
+ public void shouldNotCheckpointAfterRestorationWhenExactlyOnceEnabled() {
+ final ProcessorStateManager processorStateManager = mockStateManager();
+ recordCollector = mock(RecordCollectorImpl.class);
+
+ task = createStatefulTask(createConfig(EXACTLY_ONCE_V2, "100"), true,
processorStateManager);
+ task.initializeIfNeeded();
+ task.completeRestoration(noOpResetter -> { });
+ verify(processorStateManager, never()).checkpoint();
+ verify(processorStateManager, never()).changelogOffsets();
+ verify(recordCollector, never()).offsets();
+ }
+
+ private ProcessorStateManager mockStateManager() {
+ final ProcessorStateManager manager = spy(new ProcessorStateManager(
Review Comment:
I'm doing a partial mock here, to make sure the correct methods are being
invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
