guozhangwang opened a new pull request, #13523: URL: https://github.com/apache/kafka/pull/13523
1) I've verified and made sure the only case that `task` would be null and not stream task would be in testing code only; I've revamped the restoration recording func, mainly to make just one method on the Task interface, to make sure we would never get `task == null` and do not need to cast to `StreamTask`. 2) Use `numRecords` directly to avoid calling `records.size()` again that triggers concurrent modifications. 3) Rewrite the TaskMetricsTest to not use the removed impl functions. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
