rondagostino commented on PR #13280:
URL: https://github.com/apache/kafka/pull/13280#issuecomment-1500734932
Thanks for the review @ijuma. I think you have suggested 2 name changes:
one to rename the wrapper interfaces and one to Rena e the methods on those
interfaces.
Current interface names:
PHash{Map,Set}Wrapper
Proposed interface names:
Immutable{Map,Set}
Persistent{Map,Set}
P{Map,Set}
I don't have a strong a strong preference, so I'll go with
Immutable{Map,Set} given your comment about the potential dual meaning of
persistent.
Regarding the method names.
Current method names:
newSet = origSet.afterAdding(e);
NewMap = origMap.afterRemoving(k);
These read pretty well for me.
Proposed names:
newSet = origSet.updated(e);
newMap = origMap.removed(k);
I'm fine with this style, though maybe "origSet.added(e);" would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
