showuon commented on code in PR #13525:
URL: https://github.com/apache/kafka/pull/13525#discussion_r1163964084
##########
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##########
@@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws
IOException {
state.initialize(new OffsetAndEpoch(0L, 0));
raftMetrics = new KafkaRaftMetrics(metrics, "raft", state);
- assertEquals("unattached", getMetric(metrics,
"current-state").metricValue());
+ assertEquals("observer", getMetric(metrics,
"current-state").metricValue());
assertEquals((double) -1L, getMetric(metrics,
"current-leader").metricValue());
assertEquals((double) -1L, getMetric(metrics,
"current-vote").metricValue());
assertEquals((double) 0, getMetric(metrics,
"current-epoch").metricValue());
assertEquals((double) -1L, getMetric(metrics,
"high-watermark").metricValue());
state.transitionToFollower(2, 1);
- assertEquals("follower", getMetric(metrics,
"current-state").metricValue());
+ assertEquals("observer", getMetric(metrics,
"current-state").metricValue());
Review Comment:
@dengziming , I'm thinking add a `resigned` state is another issue we can
address (which is good to open another JIRA). But for this issue, I think what
we tried to deal with is to distinguish between `observer` and `follower`, like
what we showed to user from `kafka-metadata-quorum.sh`
[here](https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java#L147-L149).
So I think this change makes sense. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
