rreddy-22 commented on code in PR #13524:
URL: https://github.com/apache/kafka/pull/13524#discussion_r1164499488
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java:
##########
@@ -29,37 +31,53 @@ public class AssignmentMemberSpec {
/**
* The instance ID if provided.
*/
- final Optional<String> instanceId;
+ private final Optional<String> instanceId;
/**
* The rack ID if provided.
*/
- final Optional<String> rackId;
+ private final Optional<String> rackId;
/**
- * The topics that the member is subscribed to.
+ * The topicIds of topics that the member is subscribed to.
*/
- final Collection<String> subscribedTopics;
+ private final Collection<Uuid> subscribedTopics;
/**
- * The current target partitions of the member.
+ * Partitions assigned for this member keyed by topicId
*/
- final Collection<TopicPartition> targetPartitions;
+ private final Map<Uuid, Set<Integer>> assignedTopicIdPartitions;
Review Comment:
I thought it would be more clear if it was topicIdpartitions since we're
keying by topicId? Should we change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
