cadonna commented on code in PR #13529:
URL: https://github.com/apache/kafka/pull/13529#discussion_r1165561113
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2895,10 +2871,8 @@ public void
shouldNotCommitOnHandleAssignmentIfNoTaskClosed() {
expect(activeTaskCreator.createTasks(anyObject(),
eq(Collections.emptyMap()))).andReturn(Collections.emptySet());
expect(standbyTaskCreator.createTasks(eq(assignmentStandby))).andReturn(singletonList(task10));
expect(standbyTaskCreator.createTasks(eq(Collections.emptyMap()))).andReturn(Collections.emptySet());
- topologyBuilder.addSubscribedTopicsFromAssignment(eq(asList(t1p0)),
anyString());
Review Comment:
The idea is to have a unit test that specifically verifies this interaction,
i.e., `shouldAddSubscribedTopicsFromAssignmentToTopologyMetadata()` and to not
verify this interaction in the other unit tests where we verify other unrelated
aspects. I think this interaction was verified in so many unit tests before
because the topology builder mock was specified as strict and easy mock
requires to verify all interactions with strict mocks even if we actually do
not care about this interactions in some unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
