yashmayya commented on code in PR #13530:
URL: https://github.com/apache/kafka/pull/13530#discussion_r1165743153
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -229,7 +229,12 @@ private synchronized void putConnectorConfig(String
connName,
}
requestExecutorService.submit(() -> {
- updateConnectorTasks(connName);
+ try {
+ updateConnectorTasks(connName);
+ } catch (Throwable t) {
+ callback.onCompletion(t, null);
Review Comment:
That's a good point - in the unlikely but not impossible event that the
request times out (maybe due to something like slow config validation) AND the
`taskConfigs` method throws an exception, the exception will essentially get
shadowed. It doesn't hurt to log the exception here along with an appropriate
error message, so I've gone ahead and made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
