vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1166121244
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimestampedCacheFlushListener.java:
##########
@@ -47,7 +47,8 @@ public void apply(final Record<KOut,
Change<ValueAndTimestamp<VOut>>> record) {
.withValue(
new Change<>(
getValueOrNull(record.value().newValue),
- getValueOrNull(record.value().oldValue)))
+ getValueOrNull(record.value().oldValue),
+ record.value().isLatest))
Review Comment:
You mean the default `Change` constructor? That sets `isLatest` to true,
which is why it's fine to not touch anything in the caching layer at the moment
-- caching is only ever enabled for unversioned stores, where we always have
`isLatest = true` anyway.
You're right that this new functionality is not fully wired up, though. See
https://github.com/apache/kafka/pull/13564#discussion_r1166089151. I'm happy to
finish the plumbing if we think it's valuable even though it's not in use today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
