mjsax commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1167090307
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -212,11 +212,11 @@ public <K, V> void send(final String topic,
keyClass,
valueClass),
exception);
- } catch (final SerializationException exception) {
+ } catch (final Exception exception) {
Review Comment:
> I guess the intention is to catch all other errors during serialization
Yes. The only excluded case is `ClassCastException`.
> I think this is fine, I don't know if there are exceptions but I guess not
We don't really know what exception might be throw -- I guess we could relax
this to `RuntimeException` but it also does not hurt to use `Exception`.
> seems like the handler should either indicating there's an error and
rethrow or continue.
Not sure what you mean by this? Can you elaborate? If the handler itself
fail, we throw. If the handler returns `FAIL` we also re-throw the exception
(just wrapped as `StreamsException`). If the handler return `CONTINUE` we log a
WARN and continue (via `return`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
