jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167246564
########## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ########## @@ -607,6 +608,14 @@ public synchronized void handleCompletedBatch(ProducerBatch batch, ProduceRespon removeInFlightBatch(batch); } + public synchronized void transitionToUninitialized(RuntimeException exception) { + transitionTo(State.UNINITIALIZED); + lastError = null; + if (pendingTransition != null) { Review Comment: I'd prefer you confirm that it's fine. Looking at the code -- it seems to set the TransactionalRequestResult state to the error and count down the latch. Given that it is for the request -- looks to be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org