jeqo commented on PR #12637: URL: https://github.com/apache/kafka/pull/12637#issuecomment-1510491725
@C0urante thanks for such a generous review! I learnt a lot while applying suggestions. I think I covered most of them, and let a few open ones with comments to cover them. About the last suggestion and refactor, would you mind checking its format? I think GitHub Markdown has messed up the comment and it's hard for me to understand the proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org