urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1170149228
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -266,7 +266,7 @@ public synchronized TransactionalRequestResult beginAbort()
{
return handleCachedTransactionRequestResult(() -> {
if (currentState != State.ABORTABLE_ERROR)
maybeFailWithError();
- transitionTo(State.ABORTING_TRANSACTION);
+ transitionTo(State.ABORTING_TRANSACTION, null, true);
Review Comment:
there is a call chain where the Sender calls beginAbort on producer close -
do we want to throw there? I'm not sure if that one qualifies as a
"user-direct" action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
