vcrfxia commented on code in PR #13609:
URL: https://github.com/apache/kafka/pull/13609#discussion_r1170633123
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -804,6 +806,7 @@ private <VO, VR> KTable<K, VR> doJoin(final KTable<K, VO>
other,
kTableKTableJoinNode.setOutputVersioned(isOutputVersioned);
builder.addGraphNode(this.graphNode, kTableKTableJoinNode);
+ builder.addGraphNode(((KTableImpl<?, ?, ?>) other).graphNode,
kTableKTableJoinNode);
Review Comment:
I don't know why it's currently the case that primary-key table-table join
nodes only have one parent, instead of two. Seems more correct to have two, and
the GraphNode mechanism for determining whether the joining table is versioned
or not will not work without this parent connection.
I have verified that there is no change to the built topology, so AFAICT
this addition is internal-only.
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -1098,7 +1101,7 @@ private <VR, KO, VO> KTable<K, VR>
doJoinOnForeignKey(final KTable<KO, VO> forei
//not be done needlessly.
((KTableImpl<?, ?, ?>) foreignKeyTable).enableSendingOldValues(true);
- //Old values must be sent such that the
ForeignJoinSubscriptionSendProcessorSupplier can propagate deletions to the
correct node.
+ //Old values must be sent such that the
SubscriptionSendProcessorSupplier can propagate deletions to the correct node.
Review Comment:
This, and a few other similar renames in comments, are unrelated to this PR
but included as cleanup from https://github.com/apache/kafka/pull/13589.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
