vcrfxia commented on code in PR #13615:
URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110
##########
streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java:
##########
@@ -36,6 +37,7 @@
* @param value The value to update, it can be {@code null};
* if the serialized bytes are also {@code null} it is
interpreted as deletes
* @throws NullPointerException If {@code null} is used for key.
+ * @throws InvalidStateStoreException if the store is not initialized
Review Comment:
Went through and added this additional javadoc line to the methods where it
seemed to be missing. Looks like the usage throughout the codebase is very
inconsistent though:
* `RocksDBStore` enforces it on all methods even though it wasn't documented
in `KeyValueStore`. The in-memory implementations do not enforce it.
* `WindowStore` has docs about this but the actual implementations do not
enforce it.
* `VersionedKeyValueStore` has docs but the implementation was not enforcing
it. I've reconciled this inconsistency in this PR, but the others are larger
changes that I'd like to leave for later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
