dengziming commented on code in PR #13555: URL: https://github.com/apache/kafka/pull/13555#discussion_r1172598460
########## server-common/src/main/java/org/apache/kafka/purgatory/Purgatory.java: ########## @@ -26,10 +26,9 @@ /** * The purgatory which holds events that have been started, but not yet completed. - * We wait for the high water mark of the metadata log to advance before completing - * them. + * We wait for the high watermark of the log to advance before completing them. */ -class ControllerPurgatory { +public class Purgatory { Review Comment: It seems better to add a prefix since we have several `Purgatory` classes, we have a `FuturePurgatory` in raft module and its similar to this `ControllerPurgatory`, we may call it `DeferredEventPurgatory` or HwmPurgatory(high watermark). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org