mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1172621439
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java:
##########
@@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta delta) {
}
}
changes.apply(metrics);
+ if (delta.featuresDelta() != null) {
Review Comment:
I wonder if we should only set the zk state metric if we're on a
metadata.version that supports it. Otherwise we could see clusters go from NONE
-> MIGRATION -> POST_MIGRATION, which is a bit odd. (NONE is supposed to be a
terminal state)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
