mumrah commented on PR #13461:
URL: https://github.com/apache/kafka/pull/13461#issuecomment-1516441727

   > Should we wrap the calls to quotaEntityConsumer.accept (and other 
consumers) so that if it throws an exception, we log an ERROR message to log4j 
to let us know what failed?
   
   Yes, that's a good idea. I'll add this to all the externalized calls 
(consumers/visitors). 
   
   > Can we have a ZkConfigMigrationClientTest and so on, for the other new 
migrationclient classes?
   
   For sure. I'll work on these next.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to