divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1172884561
########## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import java.io.EOFException; +import java.io.IOException; +import java.io.InputStream; +import java.nio.ByteBuffer; + +/** + * ChunkedBytesStream is a ByteReader which reads from source stream in chunks of configurable size. The + * implementation of this reader is optimized to reduce the number of calls to sourceStream#read(). This works best in + * scenarios where sourceStream#read() call is expensive, e.g. when the call crosses JNI boundary. + * <p> + * The functionality of this stream is a combination of DataInput and BufferedInputStream with the following + * differences: + * - Unlike BufferedInputStream.skip() Review Comment: Fixed. ########## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import java.io.EOFException; +import java.io.IOException; +import java.io.InputStream; +import java.nio.ByteBuffer; + +/** + * ChunkedBytesStream is a ByteReader which reads from source stream in chunks of configurable size. The + * implementation of this reader is optimized to reduce the number of calls to sourceStream#read(). This works best in + * scenarios where sourceStream#read() call is expensive, e.g. when the call crosses JNI boundary. + * <p> + * The functionality of this stream is a combination of DataInput and BufferedInputStream with the following + * differences: + * - Unlike BufferedInputStream.skip() + * - Unlike BufferedInputStream, which allocates an intermediate buffer, this uses a buffer supplier to create the + * intermediate buffer + * - Unlike DataInputStream, the readByte method does not push the reading of a byte to sourceStream. + * <p> + * Note that: + * - this class is not thread safe and shouldn't be used in scenarios where multiple threads access this. + * - many method are un-supported in this class because they aren't currently used in the caller code. Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
