machi1990 commented on code in PR #13623:
URL: https://github.com/apache/kafka/pull/13623#discussion_r1173855980
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig,
*/
def shutdown(): Unit = {
info("Shutting down the log cleaner.")
- cleaners.foreach(_.shutdown())
- cleaners.clear()
+ try {
+ cleaners.foreach(_.shutdown())
+ cleaners.clear()
+ } finally {
+ remoteMetrics()
+ }
+ }
+
+ def remoteMetrics(): Unit = {
+ metricsGroup.removeMetric("max-buffer-utilization-percent")
+ metricsGroup.removeMetric("cleaner-recopy-percent")
+ metricsGroup.removeMetric("max-clean-time-secs")
+ metricsGroup.removeMetric("max-compaction-delay-secs")
+ metricsGroup.removeMetric("DeadThreadCount")
Review Comment:
Hi @divijvaidya
Just for my own understanding since I am a newbie: what happens when a
metric is removed, concretely, what happens to the already registered value?
I also have a nit suggestion of extracting the metric names onto const since
they seem to be repeated, here and during metric declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
