machi1990 commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1175200643
########## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ########## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import java.io.BufferedInputStream; +import java.io.FilterInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.nio.ByteBuffer; + +/** + * ChunkedBytesStream is a copy of {@link ByteBufferInputStream} with the following differences: + * - Unlike {@link java.io.BufferedInputStream#skip(long)} this class could be configured to not push skip() to + * input stream. We may want to avoid pushing this to input stream because it's implementation maybe inefficient, + * e.g. the case of ZstdInputStream which allocates a new buffer from buffer pool, per skip call. + * - Unlike {@link java.io.BufferedInputStream}, which allocates an intermediate buffer, this uses a buffer supplier to + * create the intermediate buffer. + * <p> + * Note that: + * - this class is not thread safe and shouldn't be used in scenarios where multiple threads access this. + * - the implementation of this class is performance sensitive. Minor changes as usage of ByteBuffer instead of byte[] Review Comment: ```suggestion * - the implementation of this class is performance sensitive. Minor changes such as usage of ByteBuffer instead of byte[] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
